Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extension point for issuer key resolution more explicit #294

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

awoie
Copy link
Collaborator

@awoie awoie commented Jan 10, 2025

This PR makes the extension point for issuer key resolution more explicit.

Preview here https://drafts.oauth.net/oauth-sd-jwt-vc/awoie/extension-point/draft-ietf-oauth-sd-jwt-vc.html

Copy link
Collaborator

@bc-pi bc-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at a minimum this PR should move the mention of DIDs in to an example of a prospective profile utilizing the now more explicit extension point

@peacekeeper
Copy link

move the mention of DIDs

It was clear in previous discussions that many WG members preferred X.509 Certificates and DID Resolution to not be removed.

Any additional key resolution mechanisms in the future can use the extension point, or - even better - can define a DID method.

Copy link

@peacekeeper peacekeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should advise that defining a new DID method and therefore re-using existing standards and infrastructure would be preferable to inventing completely new issuer key resolution mechanisms.

It's harmful for interoperability to invent a new extension mechanism for resolving issuer keys, when there is already an existing one (DID methods).

Co-authored-by: Daniel Fett <[email protected]>
@awoie
Copy link
Collaborator Author

awoie commented Jan 13, 2025

at a minimum this PR should move the mention of DIDs in to an example of a prospective profile utilizing the now more explicit extension point

As I recall, the consensus from the last interim call was to highlight how the specification can be extended to support other mechanisms, such as DIDs, by defining a profile. Therefore, this change seems reasonable.

@danielfett
Copy link
Member

I think it was quite clear in the interim that the outcome should be an extendable spec with profiles for DID living somewhere else (e.g., in the european context in ETSI). If I recall correctly, we even discussed that such a specification could focus on certain DID methods and specify anything that is required to make them work in an interoperable way.

This is also what I understood from side conversations following the interim.

@bc-pi
Copy link
Collaborator

bc-pi commented Jan 14, 2025

I think it was quite clear in the interim that the outcome should be an extendable spec with profiles for DID living somewhere else (e.g., in the european context in ETSI). If I recall correctly, we even discussed that such a specification could focus on certain DID methods and specify anything that is required to make them work in an interoperable way.

This is also what I understood from side conversations following the interim.

I was under the impression that "european" should be capitalized but otherwise concur with @danielfett's assessment.

@peacekeeper
Copy link

consensus from the last interim call

Are there meeting notes or a recording of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants